#1633 fix allow compression Android #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MateusHBR
changed the title
|
Can you resolve the conflicts and also bump the patch version? Thanks. |
|
@miguelpruivo Done! |
|
there are new conflicts. @MateusHBR can you please resolve them? thanks |
4 tasks
|
@loql-duc-luu and @miguelpruivo Done again! |
|
thank you, @MateusHBR! all green, @miguelpruivo. could you please approve and merge? thank you! |
navaronbracke
requested changes
Feb 11, 2025
CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ## 8.3.2 | |||
There was a problem hiding this comment.
This changelog entry will need to be updated to the next hotfix version. (you will need to move it to the top of this file and change the version)
android/src/main/java/com/mr/flutter/plugin/filepicker/FilePickerDelegate.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/mr/flutter/plugin/filepicker/FilePickerPlugin.java
Outdated
Show resolved
Hide resolved
pubspec.yaml
Outdated
| @@ -3,7 +3,7 @@ description: A package that allows you to use a native file explorer to pick sin | |||
| homepage: https://github.com/miguelpruivo/plugins_flutter_file_picker | |||
| repository: https://github.com/miguelpruivo/flutter_file_picker | |||
| issue_tracker: https://github.com/miguelpruivo/flutter_file_picker/issues | |||
| version: 8.3.1 | |||
| version: 8.3.2 | |||
There was a problem hiding this comment.
This version will need to be updated to the next hotfix version.
|
I went ahead and fixed the version + formatting issues. Once the checks are green this is LGTM. |
navaronbracke
approved these changes
Feb 11, 2025
|
thanks so much, @navaronbracke 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allowCompression param do not have any effect on Android
#1633