Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#970 Support setting an initial directory in getDirectoryPath() on Windows #1381

Merged
merged 4 commits into from
Mar 20, 2024
Merged

#970 Support setting an initial directory in getDirectoryPath() on Windows #1381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e33c780
Support initialDirectory in getDirectoryPath() on Windows
andreaszapf Oct 7, 2023
75b96a8
Update documentation
andreaszapf Oct 7, 2023
fd49162
Update changelog
andreaszapf Oct 7, 2023
9293e13
Update package version number
andreaszapf Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 6.2.1
### Desktop (Windows)
The `initialDirectory` parameter of `getDirectoryPath()` now works ([#970](https://github.com/miguelpruivo/flutter_file_picker/issues/970)).

## 6.2.0
### Android
Add ability to compress images on android by specifying a compression quality value ([#735]
Expand Down
2 changes: 1 addition & 1 deletion lib/src/file_picker.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ abstract class FilePicker extends PlatformInterface {
/// window). This parameter works only on Windows desktop.
///
/// [initialDirectory] can be optionally set to an absolute path to specify
/// where the dialog should open. Only supported on Linux and macOS.
/// where the dialog should open. Only supported on Linux, macOS, and Windows.
///
/// Returns a [Future<String?>] which resolves to the absolute path of the selected directory,
/// if the user selected a directory. Returns `null` if the user aborted the dialog or if the
Expand Down
25 changes: 12 additions & 13 deletions lib/src/windows/file_picker_windows.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,19 +116,18 @@ class FilePickerWindows extends FilePicker {
if (!SUCCEEDED(hr)) throw WindowsException(hr);
free(title);

// TODO: figure out how to set the initial directory via SetDefaultFolder / SetFolder
// if (initialDirectory != null) {
// final folder = TEXT(initialDirectory);
// final riid = calloc<COMObject>();
// final item = IShellItem(riid);
// final location = item.ptr;
// SHCreateItemFromParsingName(folder, nullptr, riid.cast(), item.ptr.cast());
// hr = fileDialog.AddPlace(item.ptr, FDAP.FDAP_TOP);
// if (!SUCCEEDED(hr)) throw WindowsException(hr);
// hr = fileDialog.SetFolder(location);
// if (!SUCCEEDED(hr)) throw WindowsException(hr);
// free(folder);
// }
if (initialDirectory != null) {
final folder = TEXT(initialDirectory);
final riid = convertToIID(IID_IShellItem);
final ppv = calloc<Pointer>();
hr = SHCreateItemFromParsingName(folder, nullptr, riid, ppv);
final item = IShellItem(ppv.cast());
free(riid);
free(folder);
if (!SUCCEEDED(hr)) throw WindowsException(hr);
hr = fileDialog.setFolder(item.ptr.cast<Pointer<COMObject>>().value);
if (!SUCCEEDED(hr)) throw WindowsException(hr);
}

final hwndOwner = lockParentWindow ? GetForegroundWindow() : NULL;
hr = fileDialog.show(hwndOwner);
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: A package that allows you to use a native file explorer to pick sin
homepage: https://github.com/miguelpruivo/plugins_flutter_file_picker
repository: https://github.com/miguelpruivo/flutter_file_picker
issue_tracker: https://github.com/miguelpruivo/flutter_file_picker/issues
version: 6.2.0
version: 6.2.1

dependencies:
flutter:
Expand Down
Loading