Skip to content

Latest commit

 

History

History
34 lines (28 loc) · 1.33 KB

COMMENTS.md

File metadata and controls

34 lines (28 loc) · 1.33 KB

COMMENTS

Tasks

  • Desktop layout ✅
  • Improve UI (copy good pages) ✅
  • Move types to dev dependecies ✅
  • Rename date to timestamp ✅
  • Eslint rules, add not default imports ✅
  • Implement a form library ✅
  • Implement test.each ✅
  • Implement E2E with playwright ✅
  • Implement a custom render with React Test Library ✅
  • Move the heavy lifting to the context (low level components should be as dumb as possible) ✅
  • Fix the sorting (remove useEffect add SortOptions type) ▶️
  • Research useReducer ✅

17/08/24

  • Don't use test ids ✅
  • Improve accessibility score (Lighthouse Chrome) ✅
  • Avoid array element selectors on testing ✅
  • Don't use fireEvent, use userEvent ✅
  • Playwright: one or two big tests ✅
  • Mock set local.storage ✅
  • Move sorting logic to its own function ✅
  • Unit test sorting logic ✅
  • Add date ascending and alphabetically descending order ✅

Consider

  • Bundlephobia to check libraries size
  • When writing tests try to break the code
  • When writting a component ask, "What this component does?"