Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Non Admin Backup validations around BSL usage when there is no default BSL in the DPA #158

Open
mpryc opened this issue Jan 29, 2025 · 5 comments

Comments

@mpryc
Copy link
Collaborator

mpryc commented Jan 29, 2025

Idea: "As an improvement we could add NAB level validation on BSL/NaBSL name"

This is the scenario where DPA is configured with noDefaultBackupLocation option and the user tries to create Backup without NaBSL in it.

@shubham-pampattiwar
Copy link
Member

shubham-pampattiwar commented Jan 29, 2025

Context being, allowing Non-Admin users to create NAB object using only one of the 2 possible storage locations:

  • NABSL
  • Default BSL in OADP NS

@kaovilai
Copy link
Member

  • Default BSL in OADP NS

That is my only concern here that we had discussed today.
This default BSL that NA did not create, they obviously do not have creds. If an admin is paranoid they can noDefaultBackupLocation, and any Admin BSL they require can be created manually outside dpa and/or create a non default backupLocation in dpa.

The validation here should disallow backup to a BSL in OADP namespace which do not have default set.

@kaovilai
Copy link
Member

This validation should additionally disallow any NaBSL BSLs from having default set.

@mpryc
Copy link
Collaborator Author

mpryc commented Jan 30, 2025

This validation should additionally disallow any NaBSL BSLs from having default set.

@kaovilai Is this the only one which would be "NAC Controller level | Controller Restriction" category ? We have this issue to review all of the configs across other Specs as well to find those which are considered harmful: #151

@kaovilai
Copy link
Member

This validation should additionally disallow any NaBSL BSLs from having default set.

@kaovilai Is this the only one which would be "NAC Controller level | Controller Restriction" category ? We have this issue to review all of the configs across other Specs as well to find those which are considered harmful: #151

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants