Feature/spring restapi #2
Draft
+3,455
−2,792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mieslep
reviewed
Jul 22, 2024
There was a problem hiding this comment.
why are we including certificates in the repo? Feels like this whole directory wasn't meant to be committed perhaps?
There was a problem hiding this comment.
This password should be defaulted somehow, feels like we ought to have an application-defaults.properties or at least this is the application.properties defaults, and then a separate one that gets automatically loaded in where we provide the common overrides (like SCB/username/password/keyspace)
Feature/documentation
author Senthilvel Palaniappan <senthilvel.palaniappan@gmail.com> 1721218701 -0500 committer mounaTay <mouna.tayahi@gmail.com> 1722445815 +0200 parent 440a9c1 author Senthilvel Palaniappan <senthilvel.palaniappan@gmail.com> 1721218701 -0500 committer mounaTay <mouna.tayahi@gmail.com> 1722445748 +0200 parent 440a9c1 author Senthilvel Palaniappan <senthilvel.palaniappan@gmail.com> 1721218701 -0500 committer mounaTay <mouna.tayahi@gmail.com> 1722445499 +0200 Initial version with some spring boot data
mounaTay
force-pushed
the
feature/spring-restapi
branch
from
f919c4a to
d553b2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
item get / post
feature get / post
will link up centroid similarity based index search and then add aggregation on next push