From f211ae3d9a2e9aeaf9f238de56f3650651fb8354 Mon Sep 17 00:00:00 2001 From: Alan Aldana Date: Sun, 20 Aug 2023 23:28:59 -0600 Subject: [PATCH 1/2] fix when sorting movies without search results --- projects/05-react-buscador-peliculas/src/hooks/useMovies.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/05-react-buscador-peliculas/src/hooks/useMovies.js b/projects/05-react-buscador-peliculas/src/hooks/useMovies.js index cfaa427..abb818b 100644 --- a/projects/05-react-buscador-peliculas/src/hooks/useMovies.js +++ b/projects/05-react-buscador-peliculas/src/hooks/useMovies.js @@ -28,7 +28,7 @@ export function useMovies ({ search, sort }) { }, []) const sortedMovies = useMemo(() => { - return sort + return sort && movies !== undefined ? [...movies].sort((a, b) => a.title.localeCompare(b.title)) : movies }, [sort, movies]) From 3baa88ac9fa348560337b54e6b9fe34004264f3f Mon Sep 17 00:00:00 2001 From: Alan Aldana Date: Sun, 20 Aug 2023 23:29:28 -0600 Subject: [PATCH 2/2] Corrected validation for search field --- projects/05-react-buscador-peliculas/src/App.jsx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/projects/05-react-buscador-peliculas/src/App.jsx b/projects/05-react-buscador-peliculas/src/App.jsx index 960e2f0..89ed881 100644 --- a/projects/05-react-buscador-peliculas/src/App.jsx +++ b/projects/05-react-buscador-peliculas/src/App.jsx @@ -12,10 +12,9 @@ function useSearch () { useEffect(() => { if (isFirstInput.current) { isFirstInput.current = search === '' - return } - if (search === '') { + if (search === '' && !isFirstInput.current) { setError('No se puede buscar una película vacía') return }