This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
Multiprotocol functions #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions for each protocol are created, so that they can be used even when MQTT_USE_CUSTOM_SOCKET_HANDLE is defined. The functions and types are mapped to default names in case MQTT_USE_CUSTOM_SOCKET_HANDLE is not used, so maintaining the default functionality. Co-authored-by: YAMAMOTO Takashi <yamamoto@midokura.com> Co-authored-by: Miguel Herranz <miguel@midokura.com>
maht
force-pushed
the
multiprotocol_functions
branch
from
effc0a7 to
783c6d5
Compare
lulingar
approved these changes
Jun 22, 2021
|
LGTM, though I think this only spares us this special value for the MQTT-C branch, or does it have any extra effect? |
yamt
approved these changes
Jun 22, 2021
|
@maht are you going to update LiamBindle#136 as well? |
I guess so, eventually, once we have done the release and have some time. |
ok. how about making it a draft until it happens? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create explicit functions for each PAL protocol
Functions for each protocol are created, so that they can be used even when
MQTT_USE_CUSTOM_SOCKET_HANDLEis defined.The functions and types are mapped to default names in case
MQTT_USE_CUSTOM_SOCKET_HANDLEis not used, so maintaining the default functionality.