Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: DuckStudio.GitHubView.Nightly version 2025.01.22.12907017964 #215274

Merged
merged 4 commits into from
Jan 30, 2025
Merged

New version: DuckStudio.GitHubView.Nightly version 2025.01.22.12907017964 #215274

merged 4 commits into from
Jan 30, 2025
+128 −0

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Jan 22, 2025 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Manual validation

--> Installing WinGet
--> Disabling safety warning when running installers
Tip: you can type 'Update-EnvironmentVariables' to update your environment variables, such as after installing a new software.

--> Configuring Winget
Enabled admin setting 'LocalManifestFiles'.
Enabled admin setting 'LocalArchiveMalwareScanOverride'.

--> Installing the Manifest 2025.01.22.12907017964

Found GitHubView [DuckStudio.GitHubView.Nightly] Version 2025.01.22.12907017964
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
This package requires the following dependencies:
  - Packages
      Microsoft.DotNet.Runtime.8
(1/1) Found Microsoft .NET Runtime 8.0 [Microsoft.DotNet.Runtime.8] Version 8.0.12
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://builds.dotnet.microsoft.com/dotnet/Runtime/8.0.12/dotnet-runtime-8.0.12-win-x64.exe
  ██████████████████████████████  27.2 MB / 27.2 MB
Successfully verified installer hash
Starting package install...
Successfully installed

Downloading https://github.com/DuckDuckStudio/GitHubView/releases/download/2025.01.22.12907017964/GitHubView-2025.01.22.12907017964-windows-latest-x64-Setup.exe
  ██████████████████████████████  2.04 MB / 2.04 MB
Successfully verified installer hash
Starting package install...
Successfully installed

--> Refreshing environment variables

--> Comparing ARP Entries

DisplayName                           DisplayVersion         Publisher             ProductCode                            Scope
-----------                           --------------         ---------             -----------                            -----
GitHubView 版本 2025.01.22.12907017964  2025.01.22.12907017964 鸭鸭「カモ」                GitHubView_is1                         Machine
Microsoft .NET Runtime - 8.0.12 (x64) 8.0.12.34403           Microsoft Corporation {ba2e9943-e30e-49df-89e8-7db7905c6cf0} Machine
Microsoft Reviewers: Open in CodeFlow

@Dragon1573
New version: DuckStudio.GitHubView.Nightly version 2025.01.22.1290701…
f5f6a6d 
…7964

Signed-off-by: Dragon1573 <49941141+Dragon1573@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@Dragon1573
Copy link
Contributor Author

Important

Should be reviewed by @DuckDuckStudio 🙏🏼

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 22, 2025
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jan 22, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Jan 27, 2025
@Dragon1573 @DuckDuckStudio
Apply suggestions from code review
5041d2b 
- Remove "ProductCode" from the manifest, since it's not manually configured

Co-authored-by: 鸭鸭「カモ」 <Yzcbs123@163.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed No-Recent-Activity No activity has occurred on this work item for seven days. Needs-Author-Feedback This needs a response from the author. Validation-Installation-Error Error installing application Changes-Requested Changes Requested labels Jan 28, 2025
@Dragon1573 @DuckDuckStudio
Apply suggestions from code review
97b2b82 
- Update "Release Notes"
- Update "License" and its URL, to keep syncing with the en-US version

Co-authored-by: 鸭鸭「カモ」 <Yzcbs123@163.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@Dragon1573 @DuckDuckStudio
Apply suggestions from code review
091be51 
- Switch the "Installer Locale" according to suggestions.

Co-authored-by: 鸭鸭「カモ」 <Yzcbs123@163.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jan 28, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 28, 2025
@DuckDuckStudio
Copy link
Contributor

The reason for the label Validation-Installation-Error Error installing application 's appearance remains a mystery...

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335187 2025-01-27 20:25:35.965 [FAIL] Installer failed security check. Url: https://github.com/DuckDuckStudio/GitHubView/releases/download/2025.01.22.12907017964/GitHubView-2025.01.22.12907017964-windows-latest-x64-Setup.exe Result: 0x80004005 MSI (s) (A4:18) [20:25:16:332]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'. MSI (s) (A4:18) [20:25:16:332]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'. MSI (s) (A4:18) [20:25:16:332]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'. MSI (s) (A4:18) [20:25:16:332]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'. MSI (s) (A4:18) [20:25:16:332]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'. MSI (s) (A4:18) [20:25:17:362]: Executing op: ComponentRegister(ComponentId={4C4F177D-EAA8-526E-B5BA-A435AB8AE909},KeyPath=2285\SOFTWARE\Microsoft\Windows\Windows Error Reporting\RuntimeExceptionHelperModules\C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.12\mscordaccore.dll,State=3,,Disk=1,SharedDllRefCount=0,BinaryType=1) MSI (s) (A4:18) [20:25:18:554]: Executing op: RegOpenKey(Root=-2147483646,Key=SOFTWARE\Microsoft\Windows\Windows Error Reporting\RuntimeExceptionHelperModules,,BinaryType=1,,) Property(S): ErrorDialog = ErrorDlg Property(S): OutOfDiskSpace = 0 Property(S): OutOfNoRbDiskSpace = 0 Property(S): PrimaryVolumeSpaceAvailable = 0 Property(S): PrimaryVolumeSpaceRequired = 0 Property(S): PrimaryVolumeSpaceRemaining = 0 MSI (s) (A4:6C) [20:25:23:017]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'. MSI (s) (A4:6C) [20:25:23:017]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'. MSI (s) (A4:6C) [20:25:23:017]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'. MSI (s) (A4:6C) [20:25:23:017]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'. MSI (s) (A4:6C) [20:25:23:017]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'. MSI (s) (A4:A0) [20:25:27:204]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'. MSI (s) (A4:A0) [20:25:27:204]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'. MSI (s) (A4:A0) [20:25:27:204]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'. MSI (s) (A4:A0) [20:25:27:204]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'. MSI (s) (A4:A0) [20:25:27:204]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'. 2025-01-27 20:17:27.432 [FAIL] Installer failed security check. Url: https://github.com/DuckDuckStudio/GitHubView/releases/download/2025.01.22.12907017964/GitHubView-2025.01.22.12907017964-windows-latest-x86-Setup.exe Result: 0x80004005 MSI (s) (44:F4) [20:17:19:688]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'. MSI (s) (44:F4) [20:17:19:688]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'. MSI (s) (44:F4) [20:17:19:688]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'. MSI (s) (44:F4) [20:17:19:688]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'. MSI (s) (44:F4) [20:17:19:688]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'. MSI (s) (44:F4) [20:17:20:657]: Executing op: ComponentRegister(ComponentId={BE010199-713F-57C2-9E29-CAA2CA6BC85C},KeyPath=0285\SOFTWARE\Microsoft\Windows\Windows Error Reporting\RuntimeExceptionHelperModules\C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.12\mscordaccore.dll,State=3,,Disk=1,SharedDllRefCount=0,BinaryType=0) MSI (s) (44:F4) [20:17:21:860]: Executing op: RegOpenKey(Root=-2147483646,Key=SOFTWARE\Microsoft\Windows\Windows Error Reporting\RuntimeExceptionHelperModules,,BinaryType=0,,) MSI (s) (44:14) [20:17:22:220]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'. MSI (s) (44:14) [20:17:22:220]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'. MSI (s) (44:14) [20:17:22:220]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'. MSI (s) (44:14) [20:17:22:220]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'. MSI (s) (44:14) [20:17:22:220]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'. MSI (s) (44:A0) [20:17:22:688]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'. MSI (s) (44:A0) [20:17:22:688]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'. MSI (s) (44:A0) [20:17:22:688]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'. MSI (s) (44:A0) [20:17:22:688]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'. MSI (s) (44:A0) [20:17:22:688]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.

Automated error analysis suggests -1978335187 may mean Installer failed security check.

Automated error analysis suggests 80004005 may mean Resource missing

(Automated response - build 959.)

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 29, 2025
@stephengillie
Copy link
Collaborator

#215274 (comment)

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jan 29, 2025
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jan 30, 2025
@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jan 30, 2025
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jan 30, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 640b3fc into microsoft:master Jan 30, 2025
2 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DuckDuckStudio DuckDuckStudio DuckDuckStudio approved these changes

@stephengillie stephengillie stephengillie approved these changes

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service[bot] approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Author-Feedback This needs a response from the author. New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Update Request]: DuckStudio.GitHubView.Nightly version 2025.01.22.12907017964
5 participants
@Dragon1573 @wingetbot @DuckDuckStudio @stephengillie @denelon