Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support indented here-docs (fix incorrect string highlighting) #36640

Closed
skaurus opened this issue Oct 20, 2017 · 2 comments
Closed

Support indented here-docs (fix incorrect string highlighting) #36640

skaurus opened this issue Oct 20, 2017 · 2 comments
Assignees
Labels
editor-autoindent Editor auto indentation issues

Comments

@skaurus
Copy link

skaurus commented Oct 20, 2017

I'm talking about this: http://perldoc.perl.org/perlop.html#Indented-Here-docs

Steps to Reproduce:

  1. write perl code like that:
if ($cond) {
    my $string = <<~EOF;
        indented
        text
        will be
        indented
        just by 4 spaces
        and totally not 8
    EOF
    my $res = $self->method;
}
...
  1. code after closing EOF will be colored as if it's still inside the string.

Currently it works only if opening here-doc marker does not have a tilde; AND closing marker is not indented (at all).

Reproduces without extensions: Yes

@vscodebot vscodebot bot added editor editor-autoindent Editor auto indentation issues labels Oct 20, 2017
@skaurus skaurus changed the title Support indented here-docs Support indented here-docs (incorrect string highlighting) Oct 20, 2017
@skaurus skaurus changed the title Support indented here-docs (incorrect string highlighting) Support indented here-docs (fix incorrect string highlighting) Oct 20, 2017
@skaurus skaurus closed this as completed Oct 20, 2017
@skaurus skaurus reopened this Oct 20, 2017
@mjbvz mjbvz added the php PHP support issues label Oct 20, 2017
@roblourens roblourens removed the php PHP support issues label Oct 20, 2017
@roblourens
Copy link
Member

@mjbvz This is perl, not PHP :D

@aeschli
Copy link
Contributor

aeschli commented Nov 1, 2017

This issue was moved to textmate/perl.tmbundle#26

@aeschli aeschli closed this as completed Nov 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-autoindent Editor auto indentation issues
Projects
None yet
Development

No branches or pull requests

4 participants