Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger workspace trust prompt when running commands in an untrusted workspace #20153

Open
luabud opened this issue Nov 3, 2022 · 0 comments
Open

Trigger workspace trust prompt when running commands in an untrusted workspace #20153

luabud opened this issue Nov 3, 2022 · 0 comments
Labels
area-editor-* User-facing catch-all debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on

Comments

@luabud
Copy link
Member

luabud commented Nov 3, 2022 •
edited by cwebster-99
Loading

These are the commands that we think should invoke the "trust this workspace" prompt:

  • Run and debug python file from the top-right icon/play button
  • Python: Select Interpreter
  • Python: Run Linting
  • Python: Create Environment *currently creates but does not select
  • Python: Report Issue*
  • Python: Enable/Disable Linting
  • Python: Sort Imports
  • Python: Configure Tests
  • Python: Create Terminal
  • Python: Debug Python File (should be covered by the icon)
  • Python: Launch Tensorboard
  • Python: Start REPL
  • Python: Run Selection/Line in Python Terminal
  • Python: Select Linter
  • Refresh in Test Explorer (issue needed from VS Code side)

Commands to hide in untrusted:

  • Python Run Selection/Line in Django Shell
  • Python: Clear Cache and Reload Window
  • Python Clear Workspace and Interpreter Setting
  • Python: Enable Source Map Support for Extension Debugging
  • Show all automatic debug configurations --> Python (we are not offering anything in untrusted mode)

Commands that should work under untrusted mode:

  • Python: Show Output
@luabud luabud added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Nov 3, 2022
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 3, 2022
@luabud luabud added needs spike Label for issues that need investigation before they can be worked on. and removed triage-needed Needs assignment to the proper sub-team labels Nov 3, 2022
@luabud luabud added the area-editor-* User-facing catch-all label Nov 14, 2022
@luabud luabud added needs PR Ready to be worked on and removed needs spike Label for issues that need investigation before they can be worked on. labels Dec 6, 2023
@luabud luabud changed the title Spike - which commands should trigger the "trust this workspace" prompt and which should be hidden when untrusted mode Trigger workspace trust prompt when running commands in an untrusted workspaces Dec 6, 2023
@luabud luabud changed the title Trigger workspace trust prompt when running commands in an untrusted workspaces Trigger workspace trust prompt when running commands in an untrusted workspace Dec 6, 2023
@luabud luabud mentioned this issue Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-editor-* User-facing catch-all debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luabud @cwebster-99