Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting works differently in web vs desktop #25

Open
nik72619c opened this issue Mar 4, 2024 · 6 comments
Open

Syntax highlighting works differently in web vs desktop #25

nik72619c opened this issue Mar 4, 2024 · 6 comments
Assignees

Comments

@nik72619c
Copy link

nik72619c commented Mar 4, 2024

Hi folks!
I am using vscode-oniguruma v2.0.1 for my react electron app and also a browser app. I have a custom theme config token rules applied to it but the syntax highlighting is different in both the platforms. Would be great to have some help on this.
Thanks in advance!

Here are the screenshots for web vs desktop for the same theme config
Screenshot 2024-03-04 at 5 57 03 PM
Screenshot 2024-03-04 at 5 58 48 PM

@nik72619c
Copy link
Author

cc: @alexdima @lszomoru

@RedCMD
Copy link

RedCMD commented Mar 4, 2024

what does [F1] => Developer: Inspect Editor Tokens and Scopes show?

@nik72619c
Copy link
Author

It shows identifier.js though but I think the tokenisation is different for both these platforms 🤔
For example in web, the text add (a, b) { is treated as a single element which is not the case in desktop

@nik72619c
Copy link
Author

nik72619c commented Mar 6, 2024

I notice a exactly same error as this for web but not in case of desktop

@alexdima
Copy link
Member

alexdima commented Apr 10, 2024

@nik72619c What are the steps to reproduce? Which theme are you using? I see equal results with Dark+

web:
image

desktop:
image

@marlonwq
Copy link

marlonwq commented Jan 3, 2025

It's been a while since you opened this issue, do you still need help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants