fix: re-run search if a file is reloaded from disk

Fixes #444
microsoft · Feb 2, 2024 · 87e8605 · 87e8605
1 parent 19364d7
commit 87e8605
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/media/editor/findWidget.tsx b/media/editor/findWidget.tsx
@@ -194,7 +194,7 @@ export const FindWidget: React.FC = () => {
 				clearTimeout(timeout);
 			}
 		};
-	}, [query, JSON.stringify(queryOrError), isUncapped, isCaseSensitive, isBinaryMode, edits.length - safeReplacedEditsLen.current]);
+	}, [query, JSON.stringify(queryOrError), isUncapped, isCaseSensitive, isBinaryMode, edits.length - safeReplacedEditsLen.current, results.outdated]);
 
 	const closeWidget = () => {
 		const prev = previouslyFocusedElement.current;

diff --git a/media/editor/state.ts b/media/editor/state.ts
@@ -389,6 +389,10 @@ export const searchResults = atom<SearchResultsWithProgress>({
 					: { progress: msg.data.progress, capped: msg.data.capped, results: prev.results.concat(msg.data.results) }
 				);
 			});
+
+			registerHandler(MessageType.ReloadFromDisk, () => {
+				fx.setSelf(prev => prev instanceof DefaultValue ? prev : ({ ...prev, outdated: true }));
+			});
 		}
 	],
 });

diff --git a/shared/protocol.ts b/shared/protocol.ts
@@ -92,6 +92,7 @@ export interface SearchResultsWithProgress {
 	results: SearchResult[];
 	progress: number;
 	capped?: boolean;
+	outdated?: boolean;
 }
 
 export interface SearchProgressMessage {
-Original file line number
+Diff line change
@@ Expand Up @@
     					: { progress: msg.data.progress, capped: msg.data.capped, results: prev.results.concat(msg.data.results) }
     				);
     			});
+    			registerHandler(MessageType.ReloadFromDisk, () => {
+    				fx.setSelf(prev => prev instanceof DefaultValue ? prev : ({ ...prev, outdated: true }));
+    			});
     		}
     	],
     });
@@ Expand Down @@