Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ktx] Feature tools doesn't support UWP #37387

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

LilyWangLL
Copy link
Contributor

@LilyWangLL LilyWangLL commented Mar 12, 2024

Fixes #33687.
The latest build error of ktx[core,tools]:x64-uwp as below:

[111/135] C:\PROGRA~1\MICROS~3\2022\ENTERP~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\cl.exe   /TP -DBASISU_NO_ITERATOR_DEBUG_LEVEL -DDEBUG -DFMT_SHARED -DKTX_FEATURE_KTX1 -DKTX_FEATURE_KTX2 -DKTX_FEATURE_WRITE -D_DEBUG -IF:\0218\buildtrees\ktx\src\v4.3.1-3a53d3f003\tools\imageio\. -IF:\0218\buildtrees\ktx\src\v4.3.1-3a53d3f003\utils -external:IF:\0218\buildtrees\ktx\src\v4.3.1-3a53d3f003\other_include -external:IF:\0218\buildtrees\ktx\src\v4.3.1-3a53d3f003\lib\astc-encoder\Source -external:IF:\0218\buildtrees\ktx\src\v4.3.1-3a53d3f003\lib\basisu -external:IF:\0218\buildtrees\ktx\src\v4.3.1-3a53d3f003\lib\dfdutils -external:IF:\0218\installed\x64-uwp\include -external:W0 /DWIN32 /D_WINDOWS /D_UNICODE /DUNICODE /DWINAPI_FAMILY=WINAPI_FAMILY_APP /D__WRL_NO_DEFAULT_LIB__ /nologo /Z7 /MP /GS /Gd /Gm- /W3 /WX- /Zc:wchar_t /Zc:inline /Zc:forScope /fp:precise /Oy- /EHsc  /utf-8  /D_DEBUG /MDd /Od /RTC1  -std:c++17 -MDd /W4 /utf-8 /showIncludes /Fotools\imageio\CMakeFiles\imageio.dir\imageinput.cc.obj /Fdtools\imageio\CMakeFiles\imageio.dir\imageio.pdb /FS -c F:\0218\buildtrees\ktx\src\v4.3.1-3a53d3f003\tools\imageio\imageinput.cc
FAILED: tools/imageio/CMakeFiles/imageio.dir/imageinput.cc.obj 
C:\PROGRA~1\MICROS~3\2022\ENTERP~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\cl.exe   /TP -DBASISU_NO_ITERATOR_DEBUG_LEVEL -DDEBUG -DFMT_SHARED -DKTX_FEATURE_KTX1 -DKTX_FEATURE_KTX2 -DKTX_FEATURE_WRITE -D_DEBUG -IF:\0218\buildtrees\ktx\src\v4.3.1-3a53d3f003\tools\imageio\. -IF:\0218\buildtrees\ktx\src\v4.3.1-3a53d3f003\utils -external:IF:\0218\buildtrees\ktx\src\v4.3.1-3a53d3f003\other_include -external:IF:\0218\buildtrees\ktx\src\v4.3.1-3a53d3f003\lib\astc-encoder\Source -external:IF:\0218\buildtrees\ktx\src\v4.3.1-3a53d3f003\lib\basisu -external:IF:\0218\buildtrees\ktx\src\v4.3.1-3a53d3f003\lib\dfdutils -external:IF:\0218\installed\x64-uwp\include -external:W0 /DWIN32 /D_WINDOWS /D_UNICODE /DUNICODE /DWINAPI_FAMILY=WINAPI_FAMILY_APP /D__WRL_NO_DEFAULT_LIB__ /nologo /Z7 /MP /GS /Gd /Gm- /W3 /WX- /Zc:wchar_t /Zc:inline /Zc:forScope /fp:precise /Oy- /EHsc  /utf-8  /D_DEBUG /MDd /Od /RTC1  -std:c++17 -MDd /W4 /utf-8 /showIncludes /Fotools\imageio\CMakeFiles\imageio.dir\imageinput.cc.obj /Fdtools\imageio\CMakeFiles\imageio.dir\imageio.pdb /FS -c F:\0218\buildtrees\ktx\src\v4.3.1-3a53d3f003\tools\imageio\imageinput.cc
cl : Command line warning D9025 : overriding '/W3' with '/W4'
F:\0218\buildtrees\ktx\src\v4.3.1-3a53d3f003\utils\platform_utils.h(51): error C3861: 'CommandLineToArgvW': identifier not found
F:\0218\buildtrees\ktx\src\v4.3.1-3a53d3f003\utils\platform_utils.h(69): error C2664: 'errno_t _wfopen_s(FILE **,const wchar_t *,const wchar_t *)': cannot convert argument 2 from 'const _Elem *' to 'const wchar_t *'

Function CommandLineToArgvW is from windows header file shellapi.h, but this file doesn't support UWP.
The related upstream comment: KhronosGroup/KTX-Software#800 (comment)

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Mar 12, 2024
@LilyWangLL LilyWangLL marked this pull request as ready for review March 13, 2024 02:33
@BillyONeal BillyONeal merged commit 8998330 into microsoft:master Mar 13, 2024
16 checks passed
@BillyONeal
Copy link
Member

Thanks!

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Mar 14, 2024
@LilyWangLL LilyWangLL deleted the dev/LilyWang/issue33687 branch May 29, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ktx] Build failure
3 participants