Consolidate everything back into a single crate #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrChat
force-pushed
the
user/jusmoore/symsrv_mod
branch
from
1f04c60 to
989acaf
Compare
DrChat
force-pushed
the
user/jusmoore/symsrv_mod
branch
from
989acaf to
e418992
Compare
|
btw I was playing with reporting progress in symsrv a while ago but didn't finish it, it's on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: I was planning on publishing the
symsrvcrate at one point, but honestly it's worse than the existing symsrv crate and this code has some UI-isms (like progress bars) baked into it.It would be better to hack this code up as a module to get it into some form of what we want for
pdblister, and then think about upstreaming the functionality in a better form tosymsrv.This is a reversal from #19.
For posterity, my current reasoning is that I want to play around with tracing-indicatif to change how we report progress, and maybe even take that as far as a full machine interface for
pdblisterfor use in automation.