Fix generator bugs with un-namespaced types #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #265
This fixes a few cases in which the module generator produced invalid code for un-namespaced types exported from C# with
[JSExport].I didn't add new test cases for this because it would require duplicating a lot of existing tests. But I did run all the existing module-export tests without namespaces to verify the fixes.
This does not add support for dynamic invocation of un-namespaced types. I am unsure whether it is a good idea to support that at all: with the way types from all loaded assemblies are merged into a combined namespace hierarchy, it could be easy to encounter name conflicts among un-namespaced types.