Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizations to BlobStorageEngine, ExpertLibrary #156

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

fverac
Copy link
Contributor

@fverac fverac commented Jan 22, 2025

PR for multiple speedups to uploading and downloading with blob storage.

Changes:
BlobStorageEngine

  1. Use async by default when creating a commit.
  2. When uploading/ downloading multiple blobs, use only a single blob service client.
  3. On batch upload/download, cache the last_modified value of a repo to avoid retrieving on every operation.
  4. In async_create_commit, leverage async_upload_blobs instead of _async_upload_blob.

ExpertLibrary

  1. Avoid redundant+expensive updating of readme.
  2. optimize _build_lib for BlobStorageEngine

Signed-off-by: fverac <fabioveracrespo@gmail.com>
Signed-off-by: fverac <fabioveracrespo@gmail.com>
Signed-off-by: fverac <fabioveracrespo@gmail.com>
@fverac fverac marked this pull request as ready for review January 23, 2025 01:44
Signed-off-by: fverac <fabioveracrespo@gmail.com>
@sordonia sordonia merged commit 00882d6 into microsoft:main Jan 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants