Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compatibility] Added CLIENT UNBLOCK command #886

Merged
merged 19 commits into from
Jan 28, 2025
Merged

[Compatibility] Added CLIENT UNBLOCK command #886

merged 19 commits into from
Jan 28, 2025

Conversation

Vijay-Nirmal
Copy link
Contributor

Adding the CLIENT UNBLOCK command to garnet

  • Add CLIENT UNBLOCK commands
  • Add Integration Test cases and ACL Test
  • Add documentation

TalZaccai
TalZaccai requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please see my comments.

libs/server/Objects/ItemBroker/CollectionItemBroker.cs Show resolved Hide resolved
libs/server/Resp/ClientCommands.cs Show resolved Hide resolved
libs/server/Resp/ClientCommands.cs Show resolved Hide resolved
libs/server/Resp/ClientCommands.cs Outdated Show resolved Hide resolved
libs/server/Objects/ItemBroker/CollectionItemBroker.cs Outdated Show resolved Hide resolved
libs/server/Objects/ItemBroker/CollectionItemBroker.cs Outdated Show resolved Hide resolved
libs/server/Objects/ItemBroker/CollectionItemResult.cs Outdated Show resolved Hide resolved
test/Garnet.test/RespTests.cs Outdated Show resolved Hide resolved
test/Garnet.test/RespTests.cs Outdated Show resolved Hide resolved
@Vijay-Nirmal
Copy link
Contributor Author

Fixed the review commands

TalZaccai
TalZaccai requested changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please see remaining comments :)

libs/resources/RespCommandsDocs.json Show resolved Hide resolved
@TalZaccai
Copy link
Contributor

Hey @Vijay-Nirmal! Any updates on the open comments here? :)

@Vijay-Nirmal
Copy link
Contributor Author

@TalZaccai Will work on it this weekend

@Vijay-Nirmal
Copy link
Contributor Author

@TalZaccai Fixed all review comments, sorry for the delay

TalZaccai
TalZaccai approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@TalZaccai TalZaccai merged commit 762a9d7 into microsoft:main Jan 28, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badrishc badrishc badrishc left review comments

@TalZaccai TalZaccai TalZaccai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vijay-Nirmal @TalZaccai @badrishc