Fix race condition in MainMonitor #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vazois
approved these changes
Nov 25, 2024
vazois
requested changes
Nov 25, 2024
vazois
requested changes
Nov 26, 2024
vazois
approved these changes
Nov 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a race b/w the MainMonitor task which tries to reset the latency and connection dispose path which returns the latency object after setting it to null. Under high connection dispose rate, this issue becomes visible and throws below error. Adding a lock to protect dispose. Ideally there should be handled with all public methods but based on current model only alternate code path is metrics thread, so albeit hacky, this is a solution preventing the race.
