fix: Treat HTTPException as it is, necessary to keep the original status code #1939
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Fixes
aiohttp_channel_service_exception_middleware.py
changing all HTTP errors turned into 500Description
This patch fixes
aiohttp_channel_service_exception_middleware.py
changing all HTTP errors into 500, so that applications can return any other status values, like 400.The current implementation of
aiohttp_channel_service_exception_middleware.py
catches all exceptions and raisesHTTPInternalServerError
instead of the original exception. As this applies toaiohttp.web.HTTPException
based exceptions, this prevents application code to status errors other than 500. For example, the following route results in 500 error instead of 400.Specific Changes
In order to avoid this, this patch catches HTTPException and throws as it is. The following two lines are added: