-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 02 readme -semantic kernel #89
base: main
Are you sure you want to change the base?
Conversation
…solves dependencies
👋 Thanks for contributing @wtulloch! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR updates the C# Semantic Kernel examples in the README to provide valid examples and remove deprecated planner functionality.
- Updated and corrected the base example including plugin usage and chat completion handling
- Simplified the BookTravelPlugin implementation and updated import methods for semantic functions and native functions
- Removed deprecated planner sections and updated the language in the AutoGen section
Reviewed Changes
File | Description |
---|---|
02-explore-agentic-frameworks/README.md | Updates to examples, removal of planner section, and language refinement supporting valid C# Semantic Kernel examples |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
02-explore-agentic-frameworks/README.md:516
- [nitpick] Verify whether importing native functions using both ImportPluginFromObject and ImportPluginFromType is intentional, as it may lead to redundant registrations.
kernel.ImportPluginFromType<NativeFunctions>();
AutoGen is an open-source framework developed by Microsoft Research's AI Frontiers Lab. It Focuses on event-driven, distributed *agentic* applications, enabling multiple LLMs and SLMs, tools, and advanced multi-agent design patterns. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider using a lowercase 'f' in 'focuses' for consistency with standard grammar.
AutoGen is an open-source framework developed by Microsoft Research's AI Frontiers Lab. It Focuses on event-driven, distributed *agentic* applications, enabling multiple LLMs and SLMs, tools, and advanced multi-agent design patterns. | |
AutoGen is an open-source framework developed by Microsoft Research's AI Frontiers Lab. It focuses on event-driven, distributed *agentic* applications, enabling multiple LLMs and SLMs, tools, and advanced multi-agent design patterns. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
kernel.ImportPluginFromFunctions("SemanticFunctions", [summarizeFunc]); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The array initialization syntax appears incorrect for C#. Consider using 'new[] { summarizeFunc }' instead of '[summarizeFunc]'.
kernel.ImportPluginFromFunctions("SemanticFunctions", [summarizeFunc]); | |
kernel.ImportPluginFromFunctions("SemanticFunctions", new[] { summarizeFunc }); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
The C# Semantic Kernel examples in the readme were invalid so have updated the base example and the plugin example.
Also removed the section on planners since planners have been deprecated in favour of auto invocation of functions.
The section on memory needs to be updated but still trying to find a good, simple example. :-)