Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 02 readme -semantic kernel #89

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

wtulloch
Copy link
Contributor

@wtulloch wtulloch commented Mar 8, 2025

The C# Semantic Kernel examples in the readme were invalid so have updated the base example and the plugin example.

Also removed the section on planners since planners have been deprecated in favour of auto invocation of functions.

The section on memory needs to be updated but still trying to find a good, simple example. :-)

@Copilot Copilot bot review requested due to automatic review settings March 8, 2025 23:50
Copy link

github-actions bot commented Mar 8, 2025

👋 Thanks for contributing @wtulloch! We will review the pull request and get back to you soon.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the C# Semantic Kernel examples in the README to provide valid examples and remove deprecated planner functionality.

  • Updated and corrected the base example including plugin usage and chat completion handling
  • Simplified the BookTravelPlugin implementation and updated import methods for semantic functions and native functions
  • Removed deprecated planner sections and updated the language in the AutoGen section

Reviewed Changes

File Description
02-explore-agentic-frameworks/README.md Updates to examples, removal of planner section, and language refinement supporting valid C# Semantic Kernel examples

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

02-explore-agentic-frameworks/README.md:516

  • [nitpick] Verify whether importing native functions using both ImportPluginFromObject and ImportPluginFromType is intentional, as it may lead to redundant registrations.
kernel.ImportPluginFromType<NativeFunctions>();

Comment on lines 276 to 277
AutoGen is an open-source framework developed by Microsoft Research's AI Frontiers Lab. It Focuses on event-driven, distributed *agentic* applications, enabling multiple LLMs and SLMs, tools, and advanced multi-agent design patterns.

Copy link
Preview

Copilot AI Mar 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider using a lowercase 'f' in 'focuses' for consistency with standard grammar.

Suggested change
AutoGen is an open-source framework developed by Microsoft Research's AI Frontiers Lab. It Focuses on event-driven, distributed *agentic* applications, enabling multiple LLMs and SLMs, tools, and advanced multi-agent design patterns.
AutoGen is an open-source framework developed by Microsoft Research's AI Frontiers Lab. It focuses on event-driven, distributed *agentic* applications, enabling multiple LLMs and SLMs, tools, and advanced multi-agent design patterns.

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Comment on lines +487 to +488
kernel.ImportPluginFromFunctions("SemanticFunctions", [summarizeFunc]);

Copy link
Preview

Copilot AI Mar 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The array initialization syntax appears incorrect for C#. Consider using 'new[] { summarizeFunc }' instead of '[summarizeFunc]'.

Suggested change
kernel.ImportPluginFromFunctions("SemanticFunctions", [summarizeFunc]);
kernel.ImportPluginFromFunctions("SemanticFunctions", new[] { summarizeFunc });

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants