Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EvalRunner from FunctionInvokeInfo #2819

Open
MikeStall opened this issue Jan 18, 2025 · 1 comment
Open

Remove EvalRunner from FunctionInvokeInfo #2819

MikeStall opened this issue Jan 18, 2025 · 1 comment

Comments

@MikeStall
Copy link
Contributor

MikeStall commented Jan 18, 2025

These are needed to assist in invoking lamba parameters.
But the LambdaFormulaValue present in the arguments already closes over these - so can we remove these from the info and just use via the lambda?

@MikeStall
Copy link
Contributor Author

Consider a help on LambdaFormulaValue like:

        public async ValueTask<FormulaValue> EvalInRowScopeAsync(RecordValue rowScope)
        {
            SymbolContext childContext = _context.SymbolContext.WithScopeValues(rowScope);

            var newScope = _context.NewScope(childContext);

            var result = await this.EvalInRowScopeAsync(newScope).ConfigureAwait(false);

            return result;
        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant