Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned major version for framework packages #705

Closed
wants to merge 3 commits into from
Closed

Pinned major version for framework packages #705

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7efa05
Pinned major version for framework packages.
artempushkin Nov 29, 2024
3c86ad9
Reverted Moq update.
artempushkin Nov 29, 2024
3218862
Backed out Moq changes.
artempushkin Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 19 additions & 21 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,25 +5,23 @@
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
</PropertyGroup>
<ItemGroup Label="Latest DotNet Package Versions. AutoUpdate" Condition="'$(TargetFramework)' == '$(LatestSupportedDotNetVersion)' OR '$(IsNetStandard)'">
Copy link
Member

@K-Cully K-Cully Nov 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest group shouldn't really have PreserveMajor specified if we want to follow an automated stay-current model.
Otherwise every major version bump will require manually curating every package version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer manually updating once a year after vNext release over manually downgrading each package update PR between release and adoption.

<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="9.0.0" />
<PackageVersion Include="Microsoft.Extensions.Caching.Memory" Version="9.0.0" />
<PackageVersion Include="Microsoft.Extensions.Configuration.Binder" Version="9.0.0" />
<PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="9.0.0" />
<PackageVersion Include="Microsoft.Extensions.Diagnostics.HealthChecks" Version="9.0.0" />
<PackageVersion Include="Microsoft.Extensions.Hosting" Version="9.0.0" />
<PackageVersion Include="Microsoft.Extensions.Hosting.Abstractions" Version="9.0.0" />
<PackageVersion Include="Microsoft.Extensions.Http" Version="9.0.0" />
<PackageVersion Include="Microsoft.Extensions.Logging" Version="9.0.0" />
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.0" />
<PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="9.0.0" />
<PackageVersion Include="Microsoft.Extensions.ObjectPool" Version="9.0.0" />
<PackageVersion Include="Microsoft.Extensions.Options" Version="9.0.0" />
<PackageVersion Include="Microsoft.Extensions.Options.DataAnnotations" Version="9.0.0" />
<PackageVersion Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="9.0.0" />
<PackageVersion Include="Microsoft.SourceLink.AzureRepos.Git" Version="8.0.0" />
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="9.0.0" />
<PackageVersion Include="System.Text.Json" Version="9.0.0" />
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="9.0.0" PreserveMajor="true" />
<PackageVersion Include="Microsoft.Extensions.Caching.Memory" Version="9.0.0" PreserveMajor="true" />
<PackageVersion Include="Microsoft.Extensions.Configuration.Binder" Version="9.0.0" PreserveMajor="true" />
<PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="9.0.0" PreserveMajor="true" />
<PackageVersion Include="Microsoft.Extensions.Diagnostics.HealthChecks" Version="9.0.0" PreserveMajor="true" />
<PackageVersion Include="Microsoft.Extensions.Hosting" Version="9.0.0" PreserveMajor="true" />
<PackageVersion Include="Microsoft.Extensions.Hosting.Abstractions" Version="9.0.0" PreserveMajor="true" />
<PackageVersion Include="Microsoft.Extensions.Http" Version="9.0.0" PreserveMajor="true" />
<PackageVersion Include="Microsoft.Extensions.Logging" Version="9.0.0" PreserveMajor="true" />
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.0" PreserveMajor="true" />
<PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="9.0.0" PreserveMajor="true" />
<PackageVersion Include="Microsoft.Extensions.ObjectPool" Version="9.0.0" PreserveMajor="true" />
<PackageVersion Include="Microsoft.Extensions.Options" Version="9.0.0" PreserveMajor="true" />
<PackageVersion Include="Microsoft.Extensions.Options.DataAnnotations" Version="9.0.0" PreserveMajor="true" />
<PackageVersion Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="9.0.0" PreserveMajor="true" />
<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="9.0.0" PreserveMajor="true" />
<PackageVersion Include="System.Text.Json" Version="9.0.0" PreserveMajor="true" />
</ItemGroup>
<ItemGroup Label="Previous DotNet Package Versions. AutoUpdate" Condition="'$(TargetFramework)' == '$(OldestSupportedDotNetVersion)' And '$(OldestSupportedDotNetVersion)' != '$(LatestSupportedDotNetVersion)'">
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" PreserveMajor="true" />
Expand All @@ -41,8 +39,6 @@
<PackageVersion Include="Microsoft.Extensions.Options" Version="8.0.2" PreserveMajor="true" />
<PackageVersion Include="Microsoft.Extensions.Options.DataAnnotations" Version="8.0.0" PreserveMajor="true" />
<PackageVersion Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="8.0.0" PreserveMajor="true" />
<PackageVersion Include="Microsoft.SourceLink.AzureRepos.Git" Version="8.0.0" PreserveMajor="true" />
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PreserveMajor="true" />
<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="8.0.1" PreserveMajor="true" />
<PackageVersion Include="System.Text.Json" Version="8.0.5" PreserveMajor="true" />
</ItemGroup>
Expand All @@ -52,6 +48,8 @@
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="4.11.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.Csharp" Version="4.11.0" />
<PackageVersion Include="Microsoft.Net.Test.Sdk" Version="17.12.0" />
<PackageVersion Include="Microsoft.SourceLink.AzureRepos.Git" Version="8.0.0" />
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
<PackageVersion Include="System.ComponentModel.Annotations" Version="5.0.0" />
<PackageVersion Include="System.Threading.Tasks" Version="4.3.0" />
Expand Down
Loading