-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to disable legacy telemetry #679
Merged
Gnol-VN
merged 40 commits into
main
from
dothanhl/feature/option_disable_legacyTelemetry
May 27, 2024
Merged
Option to disable legacy telemetry #679
Gnol-VN
merged 40 commits into
main
from
dothanhl/feature/option_disable_legacyTelemetry
May 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing_legacy_telemetry' into dothanhl/feature/depreacate_warning_legacy_telemetry
…legacyTelemetry' into dothanhl/feature/option_disable_legacyTelemetry
Gnol-VN
commented
May 21, 2024
…legacyTelemetry' into dothanhl/feature/option_disable_legacyTelemetry # Conflicts: # src/Logging/ServiceCollectionExtensions.cs # tests/Logging.UnitTests/OmexLoggerProviderTests.cs # tests/Logging.UnitTests/OmexLoggerUnitTests.cs
Gnol-VN
commented
May 22, 2024
tests/Activities.UnitTests/Internal/ActivitiesEventSourceTests.cs
Outdated
Show resolved
Hide resolved
tests/Activities.UnitTests/Internal/ActivitiesEventSourceTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: artempushkin <32305353+artempushkin@users.noreply.github.com>
K-Cully
reviewed
May 27, 2024
K-Cully
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this breaking change PR?
This PR to disable legacy ActivityEventSender and OmexLogger default.
How to enable legacy ActivityEventSender and OmexLogger?
In your appsettings.json, put this
You additionally need this to have these below parts to have your service recognize the appsettings.json.
Make sure that build copies this file to the output folder together with the binaries. For services using Microsoft.NET.Sdk.Web this should happen automatically. For services using Microsoft.NET.Sdk, add the following snippet to your project file:
If you are using ServiceFabric, Ensure working folder is set to CodePackage in ServiceManifest.xml
Reference: