Removing NetStandard support for OMEX

Directory.Build.props

@@ -8,8 +8,7 @@
     <OldestSupportedDotNetVersion>net8.0</OldestSupportedDotNetVersion>
     <NetCoreVersions>$(LatestSupportedDotNetVersion)</NetCoreVersions>
     <NetCoreVersions Condition="'$(LatestSupportedDotNetVersion)' != '$(OldestSupportedDotNetVersion)'">$(LatestSupportedDotNetVersion);$(OldestSupportedDotNetVersion)</NetCoreVersions>
-    <NetStandardVersions>netstandard2.0</NetStandardVersions>
-    <LibraryTargetFrameworks>$(NetCoreVersions);$(NetStandardVersions)</LibraryTargetFrameworks>
+    <LibraryTargetFrameworks>$(NetCoreVersions)</LibraryTargetFrameworks>
     <ExecutableTargetFrameworks>$(NetCoreVersions)</ExecutableTargetFrameworks>
   </PropertyGroup>
   <PropertyGroup Label="UnitTest Targets">

src/Abstractions/Validation.cs

@@ -23,7 +23,7 @@ public static string ThrowIfNullOrWhiteSpace(string? value, string? name = null)
 		{
 			if (!string.IsNullOrWhiteSpace(value))
 			{
-				return value!; // `!` required because in netstandard2.0 IsNullOrWhiteSpace does not have proper attributes
+				return value;
 			}
 
 			_ = value ?? throw new ArgumentNullException(name);

src/Activities/Internal/ActivityLoggerHelpers.cs

@@ -22,7 +22,7 @@ public static StringBuilder AppendParamName(this StringBuilder builder, string n
 			builder.Append(name).Append(':');
 
 		/// <summary>
-		/// Appends collection of key value pairs to StringBuilder, by calling ToSting on key and value
+		/// Appends collection of key value pairs to StringBuilder, by calling ToString on key and value
 		/// </summary>
 		/// <remarks>
 		/// TODO: should be replaced by AppendJoin when we remove netstandard target, since KeyValuePair also overrides ToString

src/Diagnostics.HealthChecks/Internal/HttpEndpointHealthCheck.cs

@@ -82,19 +82,12 @@ private static HttpRequestMessage CloneRequestMessage(HttpRequestMessage message
 				clone.Headers.TryAddWithoutValidation(header.Key, header.Value);
 			}
 
-#if !NETCOREAPP3_1 && !NETSTANDARD2_0
 			clone.VersionPolicy =  message.VersionPolicy;
 
 			foreach (KeyValuePair<string, object?> option in message.Options)
 			{
 				clone.Options.Set(new HttpRequestOptionsKey<object?>(option.Key), option.Value);
 			}
-#else
-			foreach (KeyValuePair<string, object> prop in message.Properties)
-			{
-				clone.Properties.Add(prop.Key, prop.Value);
-			}
-#endif
 
 			return clone;
 		}

tests/Diagnostics.HealthChecks.UnitTests/Microsoft.Omex.Extensions.Diagnostics.HealthChecks.UnitTests.csproj

@@ -9,7 +9,4 @@
     <ProjectReference Include="..\..\src\Testing.Helpers\Microsoft.Omex.Extensions.Testing.Helpers.csproj" />
     <ProjectReference Include="..\Abstractions.UnitTests\Microsoft.Omex.Extensions.Abstractions.UnitTests.csproj" />
   </ItemGroup>
-  <ItemGroup Condition="$(IsNetFramework)">
-    <Reference Include="System.Net.Http" />
-  </ItemGroup>
 </Project>

tests/ServiceFabricGuest.Abstractions.UnitTests/Microsoft.Omex.Extensions.ServiceFabricGuest.Abstractions.UnitTests.csproj

@@ -15,7 +15,4 @@
     <PackageReference Include="Newtonsoft.Json" /> <!-- Bump version of transitive dependency -->
     <PackageReference Include="ServiceFabric.Mocks" />
   </ItemGroup>
-  <ItemGroup Condition="$(IsNetFramework)">
-    <Reference Include="System.Net.Http" />
-  </ItemGroup>
 </Project>