Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnnxStaticQuantization: Remove quant_preprocess=False default for qnn ep #1565

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jambayk
Copy link
Contributor

@jambayk jambayk commented Jan 23, 2025

Describe your changes

quant_preprocess was originally set to False by default because I thought it might not be compatible with QNN EP. However, it is needed for most models for the quantization to work properly:

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

@jambayk jambayk changed the title OnnxStaticQuantization: Remove different quant_preprocess default for qnn ep OnnxStaticQuantization: Remove quant_preprocess=False default for qnn ep Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant