Skip to content

Commit 5a95c9a

Browse files
committed
CLN eval_X, eval_y in all fit signatures
1 parent b29d5c1 commit 5a95c9a

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

python-package/lightgbm/sklearn.py

+12
Original file line numberDiff line numberDiff line change
@@ -1409,6 +1409,8 @@ def fit( # type: ignore[override]
14091409
init_score: Optional[_LGBM_InitScoreType] = None,
14101410
eval_set: Optional[List[_LGBM_ScikitValidSet]] = None,
14111411
eval_names: Optional[List[str]] = None,
1412+
eval_X: Optional[Union[_LGBM_ScikitMatrixLike, Tuple[_LGBM_ScikitMatrixLike]]] = None,
1413+
eval_y: Optional[Union[_LGBM_LabelType, Tuple[_LGBM_LabelType]]] = None,
14121414
eval_sample_weight: Optional[List[_LGBM_WeightType]] = None,
14131415
eval_init_score: Optional[List[_LGBM_InitScoreType]] = None,
14141416
eval_metric: Optional[_LGBM_ScikitEvalMetricType] = None,
@@ -1424,6 +1426,8 @@ def fit( # type: ignore[override]
14241426
sample_weight=sample_weight,
14251427
init_score=init_score,
14261428
eval_set=eval_set,
1429+
eval_X=eval_X,
1430+
eval_y=eval_y,
14271431
eval_names=eval_names,
14281432
eval_sample_weight=eval_sample_weight,
14291433
eval_init_score=eval_init_score,
@@ -1522,6 +1526,8 @@ def fit( # type: ignore[override]
15221526
init_score: Optional[_LGBM_InitScoreType] = None,
15231527
eval_set: Optional[List[_LGBM_ScikitValidSet]] = None,
15241528
eval_names: Optional[List[str]] = None,
1529+
eval_X: Optional[Union[_LGBM_ScikitMatrixLike, Tuple[_LGBM_ScikitMatrixLike]]] = None,
1530+
eval_y: Optional[Union[_LGBM_LabelType, Tuple[_LGBM_LabelType]]] = None,
15251531
eval_sample_weight: Optional[List[_LGBM_WeightType]] = None,
15261532
eval_class_weight: Optional[List[float]] = None,
15271533
eval_init_score: Optional[List[_LGBM_InitScoreType]] = None,
@@ -1587,6 +1593,8 @@ def fit( # type: ignore[override]
15871593
init_score=init_score,
15881594
eval_set=valid_sets,
15891595
eval_names=eval_names,
1596+
eval_X=eval_X,
1597+
eval_y=eval_y,
15901598
eval_sample_weight=eval_sample_weight,
15911599
eval_class_weight=eval_class_weight,
15921600
eval_init_score=eval_init_score,
@@ -1768,6 +1776,8 @@ def fit( # type: ignore[override]
17681776
group: Optional[_LGBM_GroupType] = None,
17691777
eval_set: Optional[List[_LGBM_ScikitValidSet]] = None,
17701778
eval_names: Optional[List[str]] = None,
1779+
eval_X: Optional[Union[_LGBM_ScikitMatrixLike, Tuple[_LGBM_ScikitMatrixLike]]] = None,
1780+
eval_y: Optional[Union[_LGBM_LabelType, Tuple[_LGBM_LabelType]]] = None,
17711781
eval_sample_weight: Optional[List[_LGBM_WeightType]] = None,
17721782
eval_init_score: Optional[List[_LGBM_InitScoreType]] = None,
17731783
eval_group: Optional[List[_LGBM_GroupType]] = None,
@@ -1808,6 +1818,8 @@ def fit( # type: ignore[override]
18081818
group=group,
18091819
eval_set=eval_set,
18101820
eval_names=eval_names,
1821+
eval_X=eval_X,
1822+
eval_y=eval_y,
18111823
eval_sample_weight=eval_sample_weight,
18121824
eval_init_score=eval_init_score,
18131825
eval_group=eval_group,

0 commit comments

Comments
 (0)