Skip to content

Commit 05f20b2

Browse files
committed
FIX dask
1 parent 06d87a8 commit 05f20b2

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

python-package/lightgbm/dask.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -323,8 +323,8 @@ def _train_part(
323323
local_eval_X = None
324324
local_eval_y = None
325325
else:
326-
local_eval_X = ((X for X, y in local_eval_set),)
327-
local_eval_y = ((y for X, y in local_eval_set),)
326+
local_eval_X = tuple(X for X, y in local_eval_set)
327+
local_eval_y = tuple(y for X, y in local_eval_set)
328328

329329
model = model_factory(**params)
330330
if remote_socket is not None:

python-package/lightgbm/sklearn.py

+5-3
Original file line numberDiff line numberDiff line change
@@ -500,6 +500,8 @@ def _validate_eval_set_Xy(eval_set, eval_X, eval_y):
500500
if eval_set is not None:
501501
msg = "The argument 'eval_set' is deprecated, use 'eval_X' and 'eval_y' instead."
502502
warnings.warn(msg, category=LGBMDeprecationWarning, stacklevel=2)
503+
if eval_X is not None or eval_y is not None:
504+
raise ValueError("Specify either 'eval_set' or 'eval_X' and 'eval_y', but not both.")
503505
return eval_set
504506
if (eval_X is None) != (eval_y is None):
505507
raise ValueError("You must specify eval_X and eval_y, not just one of them.")
@@ -508,10 +510,10 @@ def _validate_eval_set_Xy(eval_set, eval_X, eval_y):
508510
raise ValueError("If eval_X is a tuple, y_val must be a tuple of same length, and vice versa.")
509511
if isinstance(eval_X, tuple) and len(eval_X) != len(eval_y):
510512
raise ValueError("If eval_X is a tuple, y_val must be a tuple of same length, and vice versa.")
511-
if not isinstance(eval_X, tuple):
512-
eval_set = (eval_X, eval_y)
513-
else:
513+
if isinstance(eval_X, tuple):
514514
eval_set = list(zip(eval_X, eval_y))
515+
else:
516+
eval_set = [(eval_X, eval_y)]
515517
return eval_set
516518

517519

0 commit comments

Comments
 (0)