[NFC] Remove unused functions in ExecutionTest.cpp and assert.cpp #7129
Conversation
|
LGTM |
bob80905
changed the title
bob80905
changed the title
There was a problem hiding this comment.
Can we more clearly describe the changes in the change description, rather than just the justification? Doesn't have to be long, but naming the functions removed from ExecutionTest.cpp, and clarifying that llvm_assert_trap is placed under the preprocessor condition, rather than removed, would be better when reading the description to know what changes are being made.
I also don't really like that these two are being changed in the same PR, and I think the ExecutionTest functions are potentially useful for upcoming testing work, so maybe these can be made non-static?
I've improved the description. |
…crosoft#7129) Some functions need to be removed / changed to unblock some internal pipelines. They are emitting warnings that they are unused. Specifically, `CompareOutputWithExpectedValueFloat`, `CompareOutputWithExpectedValueHalf`, and `CompareOutputWithExpectedValueFloat` need to be removed because they are unused. Additionally, there is a case in assert.cpp where `llvm_assert_trap` is left unused depending on what's been defined and how the preprocessor directives execute. This needs to be remedied so that the function is only defined when it is used.
) (#7132) Some functions need to be removed / changed to unblock some internal pipelines. They are emitting warnings that they are unused. Specifically, `CompareOutputWithExpectedValueFloat`, `CompareOutputWithExpectedValueHalf`, and `CompareOutputWithExpectedValueFloat` need to be removed because they are unused. Additionally, there is a case in assert.cpp where `llvm_assert_trap` is left unused depending on what's been defined and how the preprocessor directives execute. This needs to be remedied so that the function is only defined when it is used.
Some functions need to be removed / changed to unblock some internal pipelines. They are emitting warnings that they are unused.
Specifically,
CompareOutputWithExpectedValueFloat,CompareOutputWithExpectedValueHalf, andCompareOutputWithExpectedValueFloatneed to be removed because they are unused.Additionally, there is a case in assert.cpp where
llvm_assert_trapis left unused depending on what's been defined and how the preprocessor directives execute. This needs to be remedied so that the function is only defined when it is used.