Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement wave size range #6167

Merged
merged 15 commits into from
Jan 20, 2024
Merged

Implement wave size range #6167

merged 15 commits into from
Jan 20, 2024

Conversation

bob80905
Copy link
Collaborator

Wave Size should be able to take a range of possible wavesizes. This PR aims to implement what is described in this spec:
https://github.com/microsoft/hlsl-specs/pull/149/files

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 19, 2024 •
edited
Loading

✅ With the latest revision this PR passed the Python code formatter.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 19, 2024 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@bob80905 bob80905 force-pushed the implement_wave_size_range branch from ce52781 to 4ff306c Compare January 20, 2024 00:37
@bob80905 bob80905 marked this pull request as ready for review January 20, 2024 03:30
@bob80905 bob80905 enabled auto-merge (squash) January 20, 2024 04:04
tex3d
tex3d approved these changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to merge with follow up for some minor internal things later.

@bob80905 bob80905 merged commit 00e170f into microsoft:main Jan 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tex3d tex3d tex3d approved these changes

@llvm-beanz llvm-beanz llvm-beanz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
HLSL Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bob80905 @tex3d @llvm-beanz @pow2clk