-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM68] Add feature flag for SampleCmpBias/Grad and StartInstance/VertexLocation #6164
[SM68] Add feature flag for SampleCmpBias/Grad and StartInstance/VertexLocation #6164
Conversation
New feature flag ShaderFeatureInfo_SampleCmpGradientOrBias = 0x80000000 was added. It will be set when SampleCmpBias/Grad exists.
✅ With the latest revision this PR passed the C/C++ code formatter. |
tools/clang/test/HLSLFileCheck/hlsl/objects/Texture/has_lod_clmap.hlsl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just trying to facilitate Tex's suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. (meant to approve last time)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the quick response!
New feature flag ShaderFeatureInfo_SampleCmpGradientOrBias = 0x80000000 and
ShaderFeatureInfo_ExtendedCommandInfo = 0x100000000 were added.
They will be set when SampleCmpBias/Grad startInstance/VertexLocation exists.