Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM68] Add feature flag for SampleCmpBias/Grad and StartInstance/VertexLocation #6164

Merged

Conversation

python3kgae
Copy link
Contributor

@python3kgae python3kgae commented Jan 19, 2024

New feature flag ShaderFeatureInfo_SampleCmpGradientOrBias = 0x80000000 and
ShaderFeatureInfo_ExtendedCommandInfo = 0x100000000 were added.
They will be set when SampleCmpBias/Grad startInstance/VertexLocation exists.

New feature flag ShaderFeatureInfo_SampleCmpGradientOrBias = 0x80000000 was added.
It will be set when SampleCmpBias/Grad exists.
Copy link
Contributor

github-actions bot commented Jan 19, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

@python3kgae python3kgae changed the title [SM68] Add feature flag for SampleCmpBias/Grad. [SM68] Add feature flag for SampleCmpBias/Grad and StartInstance/VertexLocation Jan 19, 2024
@python3kgae python3kgae enabled auto-merge (squash) January 19, 2024 23:17
Copy link
Member

@pow2clk pow2clk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just trying to facilitate Tex's suggestions

Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. (meant to approve last time)

Copy link
Member

@pow2clk pow2clk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the quick response!

@python3kgae python3kgae merged commit ae9b762 into microsoft:main Jan 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants