[Sema] Not report error when invalid intrinsic call is not used.

[python3kgae]

Added DiagnoseUsedHLSLMethodCall which only report error when the MethodCall is used.
DiagnoseUsedHLSLMethodCall is used in DiagnoseTranslationUnit.
In DiagnoseTranslationUnit, traverse all visited functions in call graph, diagnose illegal intrinsic call inside these functions.

Shader kind is also checked in DiagnoseUsedHLSLMethodCall.

Fixes #5855

[bob80905]

From reading the changes, I don't think the title of the PR matches what's being done. You are separating out the logic for identifying an error, and actually emitting a diagnostic. Maybe a better title would be:
"Separate diagnostic detection logic from diagnostic emission in Sema for invalid method calls."

[python3kgae]

From reading the changes, I don't think the title of the PR matches what's being done. You are separating out the logic for identifying an error, and actually emitting a diagnostic. Maybe a better title would be: "Separate diagnostic detection logic from diagnostic emission in Sema for invalid method calls."

The implementation is updated.
Let me know if the title still needs to be change.

[bob80905]

LGTM

[llvm-beanz]

We should also probably add a test that verifies the -Wno-error= flag functionality (if it works). I don't think we have any tests running in tree that exercise that since we don't support the C++ tests.

[python3kgae]

We should also probably add a test that verifies the -Wno-error= flag functionality (if it works). I don't think we have any tests running in tree that exercise that since we don't support the C++ tests.

-Wno-error= not work :(

[llvm-beanz]

-Wno-error= not work :(

Can you file an issue for that?

[python3kgae]

-Wno-error= not work :(

Can you file an issue for that?

It works. Thought it does not work when hit lit test fail.
Added test for -Wno-error.

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[tex3d]

I think we'll want to eventually move the derivatives requirements checks into a separate function, to simplify DiagnoseUsedHLSLMethodCall when more checks are needed, but this is fine for now.