Allow unsigned int for nonzero base instance #6120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A regression was introduced by Refactor create stage vars (microsoft#6059) because it created the BaseInstance variable as an int in all cases it was created for the option vk-support-nonzero-base-instance enabled. In some cases it was used as an unsigned int. This comment get the type for BaseInstance from the type of the instance id variable, and adds a test for unsigned. Fixes microsoft#6118.
Keenuts
approved these changes
Jan 3, 2024
sudonatalie
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was introduced by Refactor create stage vars (#6059)
because it created the BaseInstance variable as an int in all cases it
was created for the option vk-support-nonzero-base-instance enabled. In
some cases it was used as an unsigned int.
This comment get the type for BaseInstance from the type of the instance
id variable, and adds a test for unsigned.
Fixes #6118.