[Validation] Add validation and tests for invalid system values in incompatible node launch type #6108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python3kgae
reviewed
Dec 14, 2023
python3kgae
reviewed
Dec 14, 2023
tex3d
requested changes
Dec 14, 2023
tools/clang/test/HLSLFileCheck/dxil/intrinsics/launch_types_broadcast.ll
Outdated
Show resolved
Hide resolved
tools/clang/test/HLSLFileCheck/dxil/intrinsics/launch_types_broadcast.ll
Outdated
Show resolved
Hide resolved
tex3d
reviewed
Dec 16, 2023
tools/clang/test/HLSLFileCheck/dxil/intrinsics/launch_types_broadcast.ll
Outdated
Show resolved
Hide resolved
bogner
reviewed
Dec 19, 2023
bogner
approved these changes
Dec 19, 2023
tex3d
reviewed
Jan 5, 2024
tex3d
reviewed
Jan 5, 2024
…f shaderkind is node before setting launchtype
python3kgae
reviewed
Jan 22, 2024
You can test this locally with the following command:darker --check --diff -r 3ef6ca2f94658de919732bae1aa03d69c003bb4b..4dcddfb10f29cb6bb5b8dd8a22a57ffda3abff2a utils/hct/hctdb.pyView the diff from darker here.--- hctdb.py 2023-12-15 00:36:28.000000 +0000
+++ hctdb.py 2024-01-24 19:25:16.774761 +0000
@@ -7553,11 +7553,11 @@
"Instr.AtomicIntrinNonUAV", "Non-UAV destination to atomic intrinsic."
)
self.add_valrule_msg(
"Instr.SVConflictingLaunchMode",
"Input system values are compatible with node shader launch mode.",
- "Call to DXIL intrinsic %0 (%1) is not allowed in node shader launch type %2"
+ "Call to DXIL intrinsic %0 (%1) is not allowed in node shader launch type %2",
)
self.add_valrule("Instr.AtomicConst", "Constant destination to atomic.")
# Work-Graphs
self.add_valrule(
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5827 first requires validation at the DXIL level. The validation will check for functions that have incompatible node launch types, and intrinsics that represent certain system values.
This PR implements this validation and adds some tests that exercise this validation.
Fixes #6104