Clean up expect type code for diagnostics #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
requested changes
Jan 4, 2024
packages/eslint-plugin/test/__file_snapshots__/types/expect-diagnostics/index.d.ts.lint
Outdated
Show resolved
Hide resolved
...int-plugin/test/__file_snapshots__/types/expect-diagnostics/expect-diagnostics-tests.ts.lint
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/test/fixtures/types/expect-diagnostics-versioned/.eslintrc.js
Show resolved
Hide resolved
sandersn
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the followup changes we discussed for #892.
Namely, determine if diagnostics should be reported first, and then pass that down so we can bail early. This should speed things up.
We don't need the precheck for being a dts file at all;
walkdoes this immediately after reporting diagnostics.I've also added a test; these fixture tests are pretty nice for being able to test different options with multiple real eslint configs.