Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phenotype: Fixed crashing when sharing photos #2155

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

DaVinci9196
Copy link
Contributor

Fixed the problem of crashing when sharing photos through links in [photos album]

@mar-v-in
Copy link
Member

This seems like a very specific hack rather than a proper fix. Based on this I would assume we run into issues with other apps/features as well. I'd rather want to see the correct behavior or a functionally equivalent behavior be implemented.

@DaVinci9196
Copy link
Contributor Author

Okay, I'll try to deal with it

@ale5000-git
Copy link
Member

@mar-v-in
Even though it isn't a proper fix, in addition of avoiding the crash it also made the feature of sharing photos through links in Google Photo really working.
I'm sure how but it works, I have tried it.

@DaVinci9196
Copy link
Contributor Author

I tried multiple times and an exception occurs when the version in the register method is 0. just return Status.CANCELED at this time to avoid exceptions

@mar-v-in mar-v-in added this to the 0.3.1 milestone Mar 7, 2024
@mar-v-in mar-v-in changed the title Fixed the problem of crashing when sharing photos Phenotype: Fixed crashing when sharing photos Mar 20, 2024
@mar-v-in mar-v-in merged commit 6f74f88 into microg:master Mar 20, 2024
1 check passed
@DaVinci9196 DaVinci9196 deleted the photos_crash branch March 27, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants