Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymous functions cause 'Unable to Open' error in VSCode #6

Open
jonathan-spruce opened this issue Feb 11, 2019 · 3 comments
Open
Labels
bug Something isn't working

Comments

@jonathan-spruce
Copy link
Collaborator

In VSCode, when clicking on the details section of a problem where the parent caller was an anonymous function, it shows an error:
screenshot 2019-02-11 at 18 05 02

We probably just need to disable trying to link at all when the parent caller is an anonymous function.

@jonathan-spruce jonathan-spruce added the bug Something isn't working label Feb 11, 2019
@tetchel
Copy link
Collaborator

tetchel commented Feb 11, 2019

They still appear under the correct file, so why shouldn't they have the same URI as the other markers on that file?
image

@jonathan-spruce
Copy link
Collaborator Author

You're right, and it also shows the line number it thinks it is. I'll do some more investigation because it looks like this should be working.

@tetchel
Copy link
Collaborator

tetchel commented Feb 15, 2019

The (1, 1) is default, it'll show even if you pass undefined or a line that doesn't exist.

Unrelated but I think it's dumb that a position is always shown because not all warnings map to a position (such as my "missing files" errors in the Microclimate extension)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants