Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name changes #140

Merged
merged 1 commit into from
Mar 5, 2025
Merged

name changes #140

merged 1 commit into from
Mar 5, 2025

Conversation

hesspnnl
Copy link
Contributor

@hesspnnl hesspnnl commented Mar 5, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your PR link to an issue?
  • Have you described the changes this PR will make?

New Notebook Submissions:

  • Have you included a summary of the notebook in the README.md included updated links to the notebook? The links in the README.md should point to where the notebooks will live once they are merged into the main branch.
  • Does your PR include links to the new notebook (in the branch) for review using nbviewer, and Colab? These are the preferred ways to review changes and additions to notebooks during review.
  • Does your PR include a test in a github workflow that tests the render-ability of your notebook?

Notebook Fix Submissions:

  • Does your PR include links to the updated notebook (in the branch) for review using nbviewer, and Colab? These are the preferred ways to review changes and additions to notebooks during review. See the guidance below for how to create these links.

Guidance for creating links to notebooks in the README.md

  • To create a Colab link for your notebook for review, use the following format:

    https://colab.research.google.com/github/microbiomedata/nmdc_notebooks/blob/your_branch/folder1/folder2/your_notebook.ipynb
    

    Replace your_branch with the branch name, folder1 and folder2 with the path to your notebook folder, and your_notebook.ipynb with the name of your notebook file.

  • To create a nbviewer link for your notebook for review, use the following format:

    https://nbviewer.org/github/microbiomedata/nmdc_notebooks/blob/your_branch/folder1/folder2/your_notebook.ipynb
    

    Replace your_branch with the branch name, folder1 and folder2 with the path to your notebook folder, and your_notebook.ipynb with the name of your notebook file.

@hesspnnl hesspnnl requested a review from simroux March 5, 2025 16:02
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@simroux simroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@simroux simroux merged commit ded5cb7 into main Mar 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants