Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for multiple sequencing runs in NEON surface water translator code #898

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

sujaypatil96
Copy link
Collaborator

@sujaypatil96 sujaypatil96 commented Feb 12, 2025

The PR updates the code in the NEON surface water translator to account for creating Manifest / manifest_set records for samples that have been sequenced multiple times. It also pulls NEON data from the latest/provisional release to update/create new DataGeneration and DataObject records for samples that were "ignored" in the first ingest.

Details

...

Related issue(s)

Fixes microbiomedata/issues#1067

Related subsystem(s)

  • Runtime API (except the Minter)
  • Minter
  • Dagster
  • Project documentation (in the docs directory)
  • Translators (metadata ingest pipelines)
  • MongoDB migrations
  • Other

Testing

  • I tested these changes (explain below)
  • I did not test these changes

I tested these changes by...

Documentation

  • I have not checked for relevant documentation yet (e.g. in the docs directory)
  • I have updated all relevant documentation so it will remain accurate
  • Other (explain below)

Maintainability

  • Every Python function I defined includes a docstring (test functions are exempt from this)
  • Every Python function parameter I introduced includes a type hint (e.g. study_id: str)
  • All "to do" or "fix me" Python comments I added begin with either # TODO or # FIXME
  • I used black to format all the Python files I created/modified
  • The PR title is in the imperative mood (e.g. "Do X") and not the declarative mood (e.g. "Does X" or "Did X")

@sujaypatil96 sujaypatil96 requested a review from aclum February 12, 2025 23:23
@sujaypatil96 sujaypatil96 merged commit 65b0607 into main Feb 13, 2025
2 checks passed
@sujaypatil96 sujaypatil96 deleted the issue-1067-multiple-seq-runs-neon-sw branch February 13, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create DataGeneration / DataObject records for the NEON surface water study
2 participants