Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure CORS to allow requests from clients hosted on GitHub Pages #533

Conversation

eecavanna
Copy link
Collaborator

@eecavanna eecavanna commented May 23, 2024

Description

In this branch, I made it so the Runtime will respond to requests originating from https://microbiomedata.github.io (i.e. web clients hosted on GitHub Pages). That will enable team members to develop unofficial web clients that can streamline certain processes while similar functionality does not exist in the Runtime (maybe by design).

Fixes #508

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

It has not been tested beyond observing that none of the GitHub Actions workflows fail with the change present.

Checklist:

  • My code follows the style guidelines of this project (have you run black nmdc_runtime/?)
    - GitHub Actions ran it for me
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (in docs/ and in https://github.com/microbiomedata/NMDC_documentation/?)
  • I have added tests that prove my fix is effective or that my feature works, incl. considering downstream usage (e.g. https://github.com/microbiomedata/notebook_hackathons) if applicable.
  • New and existing unit and functional tests pass locally with my changes (make up-test && make test-run)

@eecavanna eecavanna self-assigned this May 23, 2024
@eecavanna eecavanna linked an issue May 23, 2024 that may be closed by this pull request
@eecavanna eecavanna marked this pull request as ready for review May 25, 2024 05:41
@eecavanna
Copy link
Collaborator Author

I'm ready for this to be reviewed/merged.

@PeopleMakeCulture
Copy link
Collaborator

lgtm!

@eecavanna eecavanna merged commit fdc52b2 into main May 29, 2024
2 checks passed
@eecavanna eecavanna deleted the 508-loosen-cors-restrictions-to-allow-access-from-browser-based-clients branch May 29, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loosen CORS restrictions to allow access from browser-based clients
2 participants