-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrations: Implement bookkeeping #487
Merged
eecavanna
merged 26 commits into
main
from
432-migrations-implement-bookkeeping-so-database-tells-us-which-schema-it-conforms-to
Mar 6, 2024
Merged
Migrations: Implement bookkeeping #487
eecavanna
merged 26 commits into
main
from
432-migrations-implement-bookkeeping-so-database-tells-us-which-schema-it-conforms-to
Mar 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base-tells-us-which-schema-it-conforms-to
I don't typically submit the migration-related code for review. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this branch, I have implemented a new class. Its name is
Bookkeeper
. It can be used to do two things:Also in this branch, I have implement an example migration notebook. That can be used for team member training purposes and as a template for new migration notebooks.
Fixes #432
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration, if it is not simply
make up-test && make test-run
.python -m unittest /path/to/bookkeeper.py
at the shell of thefastapi
container.Configuration Details: Spin up a temporary Mongo server (e.g. using Docker). Then, edit the Mongo connection-related constants in
test_bookkeeper.py
accordingly.Checklist:
black nmdc_runtime/
?)docs/
and in https://github.com/microbiomedata/NMDC_documentation/?)make up-test && make test-run
)