Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add country field required by backend #232

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Add country field required by backend #232

merged 2 commits into from
Feb 18, 2025

Conversation

pkalita-lbl
Copy link
Collaborator

Fixes #230

eecavanna
eecavanna approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@eecavanna eecavanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this! The changes look straightforward to me. I'm OK with this being merged in.

@pkalita-lbl pkalita-lbl merged commit 01246f7 into main Feb 18, 2025
1 check passed
@pkalita-lbl pkalita-lbl deleted the issue-230-missing-country-field branch February 18, 2025 19:32
@eecavanna
Copy link
Collaborator

I confirmed this fixes the issue in my local environment. 👍

Before

  • on main, as of commit e24c01f, before this PR branch was merged in

image

After

  • on this PR branch, as of commit fbd2d9b

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eecavanna eecavanna eecavanna approved these changes

@yxu-lanl yxu-lanl Awaiting requested review from yxu-lanl

Assignees

@pkalita-lbl pkalita-lbl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot create Study within app
2 participants
@pkalita-lbl @eecavanna