Allow cleartext HTTP requests only in non-production builds #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119
Despite what this issue says, we didn't really need true separate environments as outlined in https://capacitorjs.com/docs/guides/environment-specific-configurations. What's written there would be necessary for controlling things like app IDs or custom URI schemes by environment. For simply enabling/disabling cleartext HTTP requests we just needed to set the
cleartext
value based onNODE_ENV
.I believe this only affects Android devices, so with
VITE_NMDC_SERVER_API_URL=http://127.0.0.1:8000
(with a localnmdc-server
instance running) the app should behave normally when running:However it should not work when running:
This is also a good reminder that we should explicitly set the
NODE_ENV
variable when we set up automated builds.