Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Apple Developer "ENT" Team ID with non-"ENT" Team ID #138

Conversation

eecavanna
Copy link
Collaborator

@eecavanna eecavanna commented Jul 25, 2024

Today, I deleted the NMDC Field Notes app identifier from the "ENT" Apple Developer account and created an NMDC Field Notes app identifier in the non-"ENT" Apple Developer account. The reason I first deleted it from the "ENT" account is so that I could use the same Bundle ID in the non-"ENT" account. The actions I took are documented in this Issue comment.

In this PR branch, I have updated all references to the Team ID so that, instead of referring to the Team corresponding to the "ENT" account (where our app identifier no longer exists), they refer to the Team corresponding to the non-"ENT" account (where our app identifier now exists).

Since I'll be out Friday, and given the specific changes involved, I may end up merging this in tonight—without review—so I can proceed to test (and, if needed, repair) deep link functionality sooner than I would otherwise be able to.

@eecavanna eecavanna self-assigned this Jul 25, 2024
@eecavanna eecavanna linked an issue Jul 25, 2024 that may be closed by this pull request
@eecavanna
Copy link
Collaborator Author

I am merging this in without review. Rationale:

  • It's after work hours
  • I want to test their effects on deep link functionality (e.g. ORCID login in the iOS simulator)
  • Tomorrow is the last day of the sprint where I'll be in the office
  • I am confident the changes won't impact the PWA or Android versions of the app
  • I'm the only person I'm aware of that uses the iOS version of the app
  • The changes are straightforward for me to revert if needed

@eecavanna eecavanna merged commit 950b7d3 into main Jul 25, 2024
1 check passed
@eecavanna eecavanna deleted the 135-update-ios-app-assets-to-reflect-new-apple-developer-account-team branch July 25, 2024 06:46
@eecavanna
Copy link
Collaborator Author

eecavanna commented Jul 25, 2024

After making this change, I confirmed that deep linking (both ORCID login and tapping on fieldnotes.microbiomedata.org/* links in other apps) still worked.

For reference: It didn't work at first/immediately. In that situation, I used Xcode to "clean the build folder" and then I used npm run sim.ios to retry simulating the app. At this point, deep linking worked. I don't know whether it was the cleaning of the build folder that fixed it, the propagation of the new app identifier through Apple's systems that fixed it, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update iOS app assets to reflect new Apple Developer Account team
1 participant