Update sample search index on changes #125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving this in draft because I don't want to merge it and update the web version until after Emiley is back from ASM Microbe.Fixes #91
Summary
The
useMiniSearch
hook we use to set up aMiniSearch
search index in theSampleList
component accepts a documents array, but it does not track changes to this list (by design). This means that as the samples list changes (e.g. a new one is added) the search index doesn't follow along. These changes use auseEffect
callback to perform a re-indexing whenever the samples list changes.Separately I noticed as I was updating the tests that we were getting a bunch of spurious warnings (for example). This was resolved by simply updating to the latest versions of
@testing-library/react
and@testing-library/user-event
.