Install madge
NPM package and eliminate circular dependencies
#116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115
Summary
These changes add a dependency on the
madge
package and connect it to a newcheck.imports
script inpackage.json
. The script is now called in the tests workflow to ensure we don't introduce new circular dependencies. In #115 I talked about usingdpdm
, but I realized after making the issues thatmadge
seems to be more popular and has more people working on it.As far as fixing the existing circular imports, all of them looked something like this:
Where the various pages & components were importing
Router.tsx
to get thepaths
object.So the fix is to move the
paths
object to a separate module and you end up with: