Do not show templates and slot modal if app metadata is not part of s…

…erver data
microbiomedata · Dec 10, 2024 · c411e9b · c411e9b
1 parent f7879b1
commit c411e9b
Showing 1 changed file with 38 additions and 28 deletions.
diff --git a/src/components/StudyView/StudyView.tsx b/src/components/StudyView/StudyView.tsx
@@ -50,6 +50,9 @@ const StudyView: React.FC<StudyViewProps> = ({ submissionId }) => {
   const templateVisibleSlots = useMemo(() => {
     const fieldVisibilityInfo: TemplateVisibleSlots[] = [];
     if (submission.data) {
+      if (!("field_notes_metadata" in submission.data)) {
+        return undefined;
+      }
       const templates = getSubmissionTemplates(submission.data);
       templates.forEach((templateName) => {
         const template = TEMPLATES[templateName];
@@ -71,7 +74,10 @@ const StudyView: React.FC<StudyViewProps> = ({ submissionId }) => {
     // them has no visible slot information (this could be because it is a brand-new study or
     // because it was created via the submission portal and this is the first time opening it in the
     // app), open the slot selector for that template.
-    if (modalTemplateVisibleSlots !== undefined) {
+    if (
+      modalTemplateVisibleSlots !== undefined ||
+      templateVisibleSlots === undefined
+    ) {
       return;
     }
     for (const item of templateVisibleSlots) {
@@ -227,33 +233,37 @@ const StudyView: React.FC<StudyViewProps> = ({ submissionId }) => {
             </IonItem>
           </IonList>
 
-          <SectionHeader>Templates</SectionHeader>
-          <IonList className="ion-padding-bottom">
-            {templateVisibleSlots.map((item) => (
-              <IonItem
-                key={item.template}
-                onClick={() => setModalTemplateVisibleSlots(item)}
-              >
-                <IonLabel>
-                  <h3>{item.templateDisplay}</h3>
-                  <p>
-                    {item.visibleSlots === undefined ? (
-                      "Not customized"
-                    ) : (
-                      <>
-                        <Pluralize
-                          count={item.visibleSlots.length}
-                          singular={"field"}
-                          showCount
-                        />{" "}
-                        selected
-                      </>
-                    )}
-                  </p>
-                </IonLabel>
-              </IonItem>
-            ))}
-          </IonList>
+          {templateVisibleSlots !== undefined && (
+            <>
+              <SectionHeader>Templates</SectionHeader>
+              <IonList className="ion-padding-bottom">
+                {templateVisibleSlots.map((item) => (
+                  <IonItem
+                    key={item.template}
+                    onClick={() => setModalTemplateVisibleSlots(item)}
+                  >
+                    <IonLabel>
+                      <h3>{item.templateDisplay}</h3>
+                      <p>
+                        {item.visibleSlots === undefined ? (
+                          "Not customized"
+                        ) : (
+                          <>
+                            <Pluralize
+                              count={item.visibleSlots.length}
+                              singular={"field"}
+                              showCount
+                            />{" "}
+                            selected
+                          </>
+                        )}
+                      </p>
+                    </IonLabel>
+                  </IonItem>
+                ))}
+              </IonList>
+            </>
+          )}
 
           <SampleList
             submission={submission.data}