Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docking: Fix allocation failure in GNOME 47 that completely broke the shell #2223

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

vanvugt
Copy link
Collaborator

@vanvugt vanvugt commented May 28, 2024

Since this._container no longer exists (gnome-shell@b58119d5c6?) in GNOME 47, allocating the entire overview would fail and the shell was non-functional.

Fixes:

Gjs-CRITICAL **: 17:10:01.720: JS ERROR: TypeError: actor is undefined
findIndexForActor@resource:///org/gnome/shell/ui/layout.js:992:22
findMonitorForActor@resource:///org/gnome/shell/ui/layout.js:999:26
_prepareMainDash/<@file:///home/dan/.local/share/gnome-shell/extensions/dash-to-dock@micxgx.gmail.com/docking.js:2233:52
@resource:///org/gnome/shell/ui/init.js:21:20

… shell

Since this._container no longer exists (gnome-shell@b58119d5c6?) in
GNOME 47, allocating the entire overview would fail and the shell was
non-functional.

Fixes:
```
Gjs-CRITICAL **: 17:10:01.720: JS ERROR: TypeError: actor is undefined
findIndexForActor@resource:///org/gnome/shell/ui/layout.js:992:22
findMonitorForActor@resource:///org/gnome/shell/ui/layout.js:999:26
_prepareMainDash/<@file:///home/dan/.local/share/gnome-shell/extensions/dash-to-dock@micxgx.gmail.com/docking.js:2233:52
@resource:///org/gnome/shell/ui/init.js:21:20
```
@vanvugt vanvugt requested a review from 3v1n0 May 28, 2024 09:17
@3v1n0 3v1n0 merged commit 9270a6e into micheleg:master Jul 2, 2024
1 check passed
@vanvugt vanvugt mentioned this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants