Added timeout on adding listeners do avoid latency issue

michaelsharman · Jun 26, 2024 · ed2b5c6 · ed2b5c6
1 parent 9ccf3c9
commit ed2b5c6
Show file tree

Hide file tree

Showing 8 changed files with 22 additions and 19 deletions.
diff --git a/dist/assessment/core.js b/dist/assessment/core.js
diff --git a/dist/assessment/index.js b/dist/assessment/index.js
diff --git a/dist/authoring/core.js b/dist/authoring/core.js
diff --git a/dist/authoring/index.js b/dist/authoring/index.js
diff --git a/dist/version.js b/dist/version.js
@@ -1 +1 @@
-export const version = '2.13.1';
+export const version = '2.13.2';
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@caspingus/lt",
-    "version": "2.13.1",
+    "version": "2.13.2",
     "description": "A utility library of helpers and tools for working with Learnosity APIs.",
     "author": "michael@learnosity.com",
     "license": "MIT",

diff --git a/src/authoring/extensions/ui/imageUploader/index.js b/src/authoring/extensions/ui/imageUploader/index.js
@@ -231,8 +231,7 @@ function setupUploderUI() {
     wrapper.setAttribute('id', 'uppy-dashboard');
     lrnImageUploader.insertAdjacentElement('afterbegin', wrapper);
 
-    const modalParent = document.querySelector('.lrn-modal-dialog');
-    prepareModalButtons(modalParent);
+    prepareModalButtons();
 
     elMoreOptions.removeAttribute('hidden');
 
@@ -438,10 +437,10 @@ function uploadImage(fileId) {
                     const src = document.querySelector('[data-authorapi-selector="asset-uploader-source"]');
                     src.value = assetUrl.trim();
                     src.dispatchEvent(new Event('input', { bubbles: true }));
+                    logger.debug('Added image path to URI', LOG_LEVEL);
 
                     setTimeout(() => {
-                        const modalParent = document.querySelector('.lrn-modal');
-                        prepareModalButtons(modalParent);
+                        prepareModalButtons();
                     }, 1500);
                 })
                 .catch(error => console.error('Error in uploading image:', error));
@@ -456,18 +455,22 @@ function uploadImage(fileId) {
  * @ignore
  * @param {object} modalParent
  */
-function prepareModalButtons(modalParent) {
+function prepareModalButtons() {
+    logger.debug('prepareModalButtons()', LOG_LEVEL);
     const elCloseButtons = ['lrn-modal-button-close', 'lrn-btn-default', 'lrn-btn-primary-legacy'];
+    const modalParent = document.querySelector('.lrn-modal');
 
     removeHandler();
 
-    for (let btn of elCloseButtons) {
-        let elBtn = modalParent.querySelector(`.lrn-modal-dialog button.${btn}`);
-        if (elBtn) {
-            logger.debug(`Adding clickHanders for: ${btn}`, LOG_LEVEL);
-            elBtn.addEventListener('click', clickHandler);
+    setTimeout(() => {
+        for (let btn of elCloseButtons) {
+            let elBtn = modalParent.querySelector(`.lrn-modal-dialog button.${btn}`);
+            if (elBtn) {
+                logger.debug(`Adding clickHanders for: ${btn}`, LOG_LEVEL);
+                elBtn.addEventListener('click', clickHandler);
+            }
         }
-    }
+    }, 750);
 
     function clickHandler() {
         logger.debug('clickHandler()', LOG_LEVEL);
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export const version = '2.13.1';
		export const version = '2.13.2';