-
Notifications
You must be signed in to change notification settings - Fork 5
Contributing? #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Some of these changes are included in #13. |
Hi! I really appreciate you finding a bit of value in this. To be honest; while I really would love to find the time to develop this out further, I don't see that happening on the near-term. The underlying projects I was working on where this work would have been applied have moved to languages other than Go, which have active Graph API libraries. I will definitely update the README to make that clear. It would probably be best if you forked it and Made It Your Own, so to speak. If you end up doing this, I'm happy to update the README to point to your repository, so no one gets too confused about the ecosystem as it stands. Last I checked there still isn't a great Go library for the Graph API, so I'm sure we could use one. Again, really appreciate the time you took on that PR. |
Understood. I definitely know how that goes. I've got a fork with these changes in |
OK, there's a fork that works over here. |
Is there any interest in accepting contributions? I have a need for a package like this, but I also need more functionality than this currently provides. Not only to be able to deal with additional API endpoints, but things like
context.Context
support and being able to specify anhttp.Client
to use (http.DefaultClient
doesn't have a timeout on it, so should be used with caution; I generally avoid it).Is there any interest in this sort of thing being contributed back to this repo?
The text was updated successfully, but these errors were encountered: