exported: report differently a method that is now exported

[ccoVeille]

package sandbox

// Foo is OK
func Foo() {}

// fooBarQuux was not exported but is now exported
func FooBarQuux() {}

revive reports the right things yet, but it could be improved.

Here we are 100% sure the issue is the fact the method is now exported, but wasn't before

But because golangci-lint exclude EXC0012 by default.
This one is not reported via golangci-lint.

We should consider trying to detect it, and report another message that won't be caught by EXC0012

Here the idea is to compare that only the case of the first letter differ.

Please note #1235 is a special case of #1236

• exported: report differently a method that is now exported #1235
• exported: report differently a method that case was altered #1236

[chavacava]

@ccoVeille what message could we report for these cases?

[ccoVeille]

Let's consider #1236 with this issue for providing a wording.

So we already have this error messages

• exported (.+) should have comment( (or a comment on this block))? or be unexported

• comment on exported (.+) should be of the form "(.+)..."

• package comment should be of the form "(.+)..."

• should have a package comment

These are respectively, exc0012, exc0013, exc0014, exc0015

Here are some suggestions:

• invalid name in comment: expected 'FooBarQuux', not 'fooBarQuux'.
• invalid name in comment: expected 'FooBarQuux', got 'fooBarQuux'.
• comment should start with 'FooBarQuux', not 'fooBarQuux'
• comment should start with 'FooBarQuux', got 'fooBarQuux'